updated user query to select Active Standard users#2845
Open
timbarton1966 wants to merge 3 commits intomainfrom
Open
updated user query to select Active Standard users#2845timbarton1966 wants to merge 3 commits intomainfrom
timbarton1966 wants to merge 3 commits intomainfrom
Conversation
nchitre-sf
previously approved these changes
Sep 23, 2024
Contributor
|
jstvz
previously approved these changes
Sep 26, 2024
Contributor
|
@timbarton1966 - can you please check the query and fix the error ? |
jstvz
reviewed
Nov 18, 2024
Contributor
jstvz
left a comment
jstvz
left a comment
There was a problem hiding this comment.
These tests are a little weird. You'll need to update this line to match the new query:
updated unit test
jstvz
approved these changes
Nov 19, 2024
nchitre-sf
approved these changes
Nov 20, 2024
Contributor
nchitre-sf
left a comment
nchitre-sf
left a comment
There was a problem hiding this comment.
Changes look good and unit tests are passing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated packaging org user report query to only select UserType=Standard users.
This will make the packaging org report reflect the same user list as in the UI for a packaging org.